Thank you for your thoughtful and helpful reply, and I hope I can help shed some further light on some of the Sale-Broaddus marriages, etc.
I would rule out Thomas Broaddus, Jr. as the father of the Sally Broaddus who married Robert Sale.There is a Sally Broaddus in the Caroline Co. marriage records who married Thomas Goldwin Puller (Thomas and Sally were the parents of John B. Puller who married Elizabeth Sale.)While I cannot prove from primary documents that the Sally Broaddus who married Thomas Goldwin Puller was the daughter of Thomas Broaddus, Jr., this is the information handed down by Andrew Broaddus in his "History of the Broaddus Family" (p. 41).
As to the marriages of Robert Sale to Ann Puller in 1818 and to Catherine Broaddus in 1823, I do not see how the same man married each of these women.My reaction is to suppose that there were two men by this name (perhaps cousins) born about the same time.
It is unfortunate that there is no date on the abstract of the Chancery Suit between Thomas Puller and Sally Sale.Since we are left to guess, my hypothesis is that it took place soon after the birth of Elizabeth and before the birth of Edmund, who I believe was one of Sally's children.Let's assume that Lucy and Redd were the first two children of Robert Sale, Sr. and were already over 21 at the time of the suit (probably born about 1795 and 1796 respectively, soon after Robert, Sr. and Ann were married in Nov. 1794).Elizabeth Sale was likely born a couple of years or so after Robert, Sr. and Sally married in 1813, and then Edmund was born shortly thereafter (he is known to have married Martha Broaddus in 1839, so this birth date works out).Thus, if the Chancery Suit was around 1816 or 1817 (before Edmund's birth), this would explain why Edmund was not mentioned, why Elizabeth and Robert, Jr. were still minors and Lucy and Redd were not.I realize this is guess work, but it also fits in with Andrew Broaddus' view that Robert and Ann had three children, and with the claim of Noel researchers that Robert and Sally's children were Elizabeth and Edmund.