I think that you are correct in identifying Sally Broaddus, who married Thomas Puller as a daughter of Thomas Broaddus, Jr. In fact, the marriage record referenced on page 233 of Hopkins' book states that she was a daughter of Thomas Broaddus and gave the date of 18 Jan 1804. They were married by Richard Broaddus and Mordecai Broaddus was security and witness. Since the record did not state that Thomas Broaddus was deceased, this would indicate that her father was Thomas Broaddus, Jr.
I believe that Andrew Broaddus mistakenly used the name Goldwin to identify the Thomas Puller, who married Sally Broaddus. The name actually used in the Puller Family was Goulder or Goalder, which is believed to be the maiden name of the wife of the first John Puller, who moved to Caroline County (from Petsworth Parish, Gloucester County, VA). Other records in Caroline and King William County identified Thomas, who married Sally Broaddus, simply as Thomas Puller.
The confusion may have been caused by the fact that Goulder Puller, the uncle of Thomas, married Elizabeth Broaddus, daughter of Thomas Broaddus, Senior, and Ann Redd. To understand how the Pullers all fit together, one has to readthe will of John Puller of Culpeper County, who was the brother of Goulder and James Puller. James Puller was the father of Thomas, who married Sally Broaddus.
Goulder and Elizabeth Broaddus Puller had Thomas Broaddus Puller, William Dandridge Puller and Catherine Puller, who married Archibald Thomas. Thomas Broaddus Puller married Lucy Ann Sale and lived successively in Hanover County and King William County, where he purchased "Seven Springs", the old Dabney home. William Dandridge Puller married Catherine Broaddus and lived for a while in King William, where his death was recorded in 1828. To make things really confusing, Thomas Puller and his wife Sally Broaddus bought a farm in King William, which was near "Seven Springs"; and lived there until their deaths, which occurred before 1833 (when the land was divided among their heirs: Wiiliam E., Martha E., Harriet E., John B. and Thomas W.Puller).
The children of Thomas Broaddus Puller and Lucy Ann Sale were: Margaret Ann Puller, who married Eldred W. Satterwhite; Goalder W. Puller, who married Margaret E. Lipscomb and Andrew Broaddus Puller, wo married Elizabeth Carter Turner. Goalder W. Puller moved to Hanover County, VA and Andrew Broaddus Puller inherited "Seven Springs", in King William County. As stated previously, it was adjacent to "Seven Springs" that Robert Sale, Jr. and his common-law wife, Sally Spurlock, and their family lived.